Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Refactored sort query parameter handling in schema generation #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sliverc merged 2 commits into django-json-api:main from atkallie:sort-refactor
Feb 1, 2023

Conversation

Copy link
Contributor

@atkallie atkallie commented Jan 30, 2023 •
edited
Loading

Fixes #1120

Description of the Change

Refactored sort query parameter handling in order to avoid duplicate declarations in the generated schema for each endpoint.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Copy link
Member

sliverc commented Jan 31, 2023

Looks good to me. Could you add yourself to AUTHORS and add a changelog entry? Then we will be ready to merge it.
atkallie reacted with hooray emoji

Copy link
Contributor Author

Okay, awesome. Just did. Merging this will close out #1120, but if you need a hand with the second part of the issue (sort on single resources) just let me know where you want to continue that discussion (reopen #1120 or somewhere else?).

Copy link
Member

sliverc commented Feb 1, 2023

Great, thanks. I will merge this. In terms of sort on single resources, I have a feeling there won't be an easy fix and we should have a broader discussion. Could you open a discussion explaining the issue, potential workarounds, etc.? We can then discuss there what a way forward is.
atkallie reacted with thumbs up emoji

@sliverc sliverc merged commit 735ce29 into django-json-api:main Feb 1, 2023
Copy link
Contributor Author

atkallie commented Feb 6, 2023

Awesome. And yeah, sure thing. I'll open up the discussion once I've had some time to explore some potential workarounds.
sliverc reacted with thumbs up emoji

@atkallie atkallie deleted the sort-refactor branch March 10, 2023 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sliverc sliverc sliverc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect handling of sort field in schema generation
2 participants

AltStyle によって変換されたページ (->オリジナル) /