-
Notifications
You must be signed in to change notification settings - Fork 299
Resolved inflecting component attributes in OpenAPI SchemaGenerator #1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4368340 to
160825b
Compare
Amended commit with flake8. All tests passing on python3.7
160825b to
d390638
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Your changes look good. The snapshottest seems to have messed up the order of the tests though and therefore the diff is not really readable...
Actually as snapshottest is not really maintained I wanted to switch to a different snapshot tool anyway which will also produce better diff results. So I will do this in another PR and once merged this PR can be rebased.
In the mean time could add yourself to AUTHORS and add a changelog entry? Thanks.
d390638 to
c234b37
Compare
@sliverc Amended. Can you please label this PR as hacktoberfest-accepted ? Thank you
@sliverc Amended. Can you please label this PR as hacktoberfest-accepted ? Thank you
Sure. Added. I hope to have this merged soon though.
c234b37 to
5ac1607
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased to master and updated syrupy snapshots... now the snapshot diff is readable... 👍 For me this PR looks good.
@n2ygk As you have a better understanding of the open api schema could you have a look at this PR as well? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for this.
Uh oh!
There was an error while loading. Please reload this page.
Fixes #967
Description of the Change
applied format_field_name to 3 instances of field.field_name and update snapshot
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS