Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add codecov configuration #1002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n2ygk merged 1 commit into django-json-api:master from sliverc:codecov-conf
Oct 27, 2021
Merged

Conversation

Copy link
Member

@sliverc sliverc commented Oct 22, 2021
edited
Loading

Description of the Change

  • Ensure that PR covers 100% of diff (codecov/patch check)
  • Disable project coverage as it may be misleading. (See clean python 2 codes #976 as an example where codecov/project fails as overall coverage is lower but actually in this case it is lower because code got removed).
  • Disable GitHub comments to avoid notifications

Once this is merged we can make codecov/patch a requirement so PR won't be mergeable if diff is not covered. In the rare cases where a code bit cannot be tested it should be marked as # pragma: no cover in the code to make it clear.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@sliverc sliverc requested a review from n2ygk October 22, 2021 17:25
Copy link

codecov bot commented Oct 22, 2021
edited
Loading

Codecov Report

Merging #1002 (71a609b) into master (c4337f1) will not change coverage.
The diff coverage is n/a.

❗ Current head 71a609b differs from pull request most recent head 0eb44af. Consider uploading reports for the commit 0eb44af to get more accurate results
Impacted file tree graph

@@ Coverage Diff @@
## master #1002 +/- ##
=======================================
 Coverage 96.84% 96.84% 
=======================================
 Files 65 65 
 Lines 3925 3925 
=======================================
 Hits 3801 3801 
 Misses 124 124 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4337f1...0eb44af. Read the comment docs.

* Ensure that PR covers 100% of diff
* Disable project coverage as it may be misleading
* Disable github comment to avoid notifications
@n2ygk n2ygk merged commit 2d00b01 into django-json-api:master Oct 27, 2021
@sliverc sliverc deleted the codecov-conf branch December 28, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n2ygk n2ygk n2ygk approved these changes

+1 more reviewer

@auvipy auvipy auvipy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /