Commit 54f1dcd

tpilarascottfisk

authored and

committed

Fix return stale data on PATCH to-one relationship (#247)

1 parent d3eac6d commit 54f1dcdCopy full SHA for 54f1dcd

File tree

-0

lines changed

-0

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,7 @@ def test_patch_to_one_relationship(self):`
`101`	`101`	`}`
`102`	`102`	`response = self.client.patch(url, data=json.dumps(request_data), content_type='application/vnd.api+json')`
`103`	`103`	`assert response.status_code == 200, response.content.decode()`
	`104`	`+ assert response.data == request_data['data']`
`104`	`105`
`105`	`106`	`response = self.client.get(url)`
`106`	`107`	`assert response.data == request_data['data']`
`@@ -112,6 +113,7 @@ def test_patch_to_many_relationship(self):`
`112`	`113`	`}`
`113`	`114`	`response = self.client.patch(url, data=json.dumps(request_data), content_type='application/vnd.api+json')`
`114`	`115`	`assert response.status_code == 200, response.content.decode()`
	`116`	`+ assert response.data == request_data['data']`
`115`	`117`
`116`	`118`	`response = self.client.get(url)`
`117`	`119`	`assert response.data == request_data['data']`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -99,6 +99,7 @@ def patch(self, request, args, *kwargs):`
`99`	`99`	`serializer.is_valid(raise_exception=True)`
`100`	`100`	`setattr(parent_obj, self.get_related_field_name(), serializer.validated_data)`
`101`	`101`	`parent_obj.save()`
	`102`	`+ related_instance_or_manager = self.get_related_instance() # Refresh instance`
`102`	`103`	`result_serializer = self._instantiate_serializer(related_instance_or_manager)`
`103`	`104`	`return Response(result_serializer.data)`
`104`	`105`

Comments

(0)