Commit d3eac6d

tpilarascottfisk

authored and

committed

Require 'id' is included in PATCH request (#245)

* Require 'id' included in PATCH request * Add missing 'id' to test

1 parent bd9b5a5 commit d3eac6dCopy full SHA for d3eac6d

File tree

+22

-0

lines changed

+22

-0

lines changed

Lines changed: 19 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -184,6 +184,25 @@ def test_key_in_detail_result(self):`
`184`	`184`
`185`	`185`	`assert expected_dump == content_dump`
`186`	`186`
	`187`	`+ def test_patch_requires_id(self):`
	`188`	`+ """`
	`189`	`+ Verify that 'id' is required to be passed in an update request.`
	`190`	`+ """`
	`191`	`+ data = {`
	`192`	`+ 'data': {`
	`193`	`+ 'type': 'users',`
	`194`	`+ 'attributes': {`
	`195`	`+ 'first-name': 'DifferentName'`
	`196`	`+ }`
	`197`	`+ }`
	`198`	`+ }`
	`199`	`+`
	`200`	`+ response = self.client.patch(self.detail_url,`
	`201`	`+ content_type='application/vnd.api+json',`
	`202`	`+ data=dump_json(data))`
	`203`	`+`
	`204`	`+ self.assertEqual(response.status_code, 400)`
	`205`	`+`
`187`	`206`	`def test_key_in_post(self):`
`188`	`207`	`"""`
`189`	`208`	`Ensure a key is in the post.`

Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -155,6 +155,7 @@ def test_delete_relationship_overriding_with_none(self):`
`155`	`155`	`request_data = {`
`156`	`156`	`'data': {`
`157`	`157`	`'type': 'comments',`
	`158`	`+ 'id': self.second_comment.id,`
`158`	`159`	`'relationships': {`
`159`	`160`	`'author': {`
`160`	`161`	`'data': None`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,8 @@ def parse(self, stream, media_type=None, parser_context=None):`
`80`	`80`	`resource_type=resource_name`
`81`	`81`	`)`
`82`	`82`	`)`
	`83`	`+ if not data.get('id') and request.method in ('PATCH', 'PUT'):`
	`84`	`+ raise ParseError("The resource identifier object must contain an 'id' member")`
`83`	`85`
`84`	`86`	`# Construct the return data`
`85`	`87`	`parsed_data = {'id': data.get('id')}`

Comments

(0)