Commit 53fdfcb

committed

Merge pull request #129 from django-json-api/bugfix/duplicate-included-records

Accessing by index on Model.objects.all() produces weird behavior

2 parents 0c5e51a + fb8f30c commit 53fdfcbCopy full SHA for 53fdfcb

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -366,7 +366,7 @@ def extract_relationships(fields, resource, resource_instance):`
`366`	`366`	`relation_data = list()`
`367`	`367`
`368`	`368`	`serializer_data = resource.get(field_name)`
`369`		`- resource_instance_queryset = relation_instance_or_manager.all()`
	`369`	`+ resource_instance_queryset = list(relation_instance_or_manager.all())`
`370`	`370`	`if isinstance(serializer_data, list):`
`371`	`371`	`for position in range(len(serializer_data)):`
`372`	`372`	`nested_resource_instance = resource_instance_queryset[position]`
`@@ -438,7 +438,7 @@ def extract_included(fields, resource, resource_instance, included_resources):`
`438`	`438`	`serializer = field.child`
`439`	`439`	`model = serializer.Meta.model`
`440`	`440`	`relation_type = format_relation_name(model.__name__)`
`441`		`- relation_queryset = relation_instance_or_manager.all()`
	`441`	`+ relation_queryset = list(relation_instance_or_manager.all())`
`442`	`442`
`443`	`443`	`# Get the serializer fields`
`444`	`444`	`serializer_fields = get_serializer_fields(serializer)`

Comments

(0)