Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit 0c5e51a

Browse files
committed
Merge pull request #128 from django-json-api/revert-127-develop
Revert "Fix the inclusion of relations"
2 parents 68b59e6 + 444feab commit 0c5e51a

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

‎rest_framework_json_api/utils.py‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -413,13 +413,14 @@ def extract_included(fields, resource, resource_instance, included_resources):
413413
if not isinstance(field, (RelatedField, ManyRelatedField, BaseSerializer)):
414414
continue
415415

416-
if field_name not in included_resources:
416+
try:
417+
included_resources.remove(field_name)
418+
new_included_resources = [key.replace('%s.' % field_name, '', 1) for key in included_resources]
419+
relation_instance_or_manager = getattr(resource_instance, field_name)
420+
serializer_data = resource.get(field_name)
421+
except ValueError:
417422
# Skip fields not in requested included resources
418423
continue
419-
420-
new_included_resources = [key.replace('%s.' % field_name, '', 1) for key in included_resources]
421-
relation_instance_or_manager = getattr(resource_instance, field_name)
422-
serializer_data = resource.get(field_name)
423424

424425
if isinstance(field, ManyRelatedField):
425426
serializer_class = included_serializers.get(field_name)

0 commit comments

Comments
(0)

AltStyle によって変換されたページ (->オリジナル) /