Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Role page button bug#485

Open
eguerrant wants to merge 1 commit into
main from
externally_managed_roles_button
Open

Role page button bug #485
eguerrant wants to merge 1 commit into
main from
externally_managed_roles_button

Conversation

@eguerrant

@eguerrant eguerrant commented Jun 12, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

This PR fixes several issues with the 'Add Groups'/'Add Owner Groups' buttons on role list pages

  • Buttons are now displayed to admins on externally managed role pages
  • Buttons will only appear to non-admins if they own a role and also own groups that do no have tag constraints that would prevent them from adding the role to the group
  • Removed disallowedGroups since it did not work and was dead code
  • Fixed dialog group filter (constraint and ownership aware)
  • Make the group selection dropdown in the dialog prepopulate available groups
  • Corrected dialog informational message and added part about tag constraints

No visual changes besides updating informational message

Also fixed an issue with the app not loading in local dev

@eguerrant eguerrant marked this pull request as ready for review June 12, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@somethingnew2-0 somethingnew2-0 somethingnew2-0 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /