Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: missing Slack notifications for group request created and completed events#442

Open
elaynelemos wants to merge 1 commit into
discord:main from
elaynelemos:bugfix/group-requests-notification
Open

fix: missing Slack notifications for group request created and completed events #442
elaynelemos wants to merge 1 commit into
discord:main from
elaynelemos:bugfix/group-requests-notification

Conversation

@elaynelemos

@elaynelemos elaynelemos commented May 12, 2026

Copy link
Copy Markdown

Adds the two missing hook implementations to Slack notification plugin (examples/plugins/notifications_slack/notifications.py):

  • access_group_request_created: DMs each approver, DMs the requester when they aren't already in the approver list, and posts to the alerts channel. Links to /group-requests/{id}.
  • access_group_request_completed: DMs the requester when notify_requester=True, DMs each approver other than the requester, and posts to the alerts channel. Uses the created group's name when approved, falling back to the resolved/requested name on rejection.

@elaynelemos elaynelemos force-pushed the bugfix/group-requests-notification branch from 7c974b3 to d3c4097 Compare May 12, 2026 17:49

Copy link
Copy Markdown
Collaborator

@elaynelemos thank you for the contribution and sorry for the delayed review!

Could you rebase the PR off of main and fix the ruff linting issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eguerrant eguerrant Awaiting requested review from eguerrant

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /