-
Notifications
You must be signed in to change notification settings - Fork 561
fix GitHub and GitLab spelling to a correct one #2008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
17a4cf0
225c796
c6fb997
bc3faa5
3cdfea8
abf2a83
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -43,10 +43,10 @@ generate_projects: | |
|
||
# Assume role with cognito identity | ||
|
||
The github action JWT token includes alot of useful fields such as `ref`, `sha`, `runner_environment` etc. however it is | ||
The GitHub action JWT token includes alot of useful fields such as `ref`, `sha`, `runner_environment` etc. however it is | ||
challenging to write an AWS trust policy to match for these fields since only `aud` and `sub` fields are supported. Using cognito | ||
identity it is possible to remap the fields into principal tags which allows them to be matched in the trust policy. More information | ||
about this is in this article: https://catnekaise.github.io/github-actions-abac-aws/cognito-identity/. | ||
about this is in this article: https://catnekaise.GitHub.io/GitHub-actions-abac-aws/cognito-identity/. | ||
|
||
Comment on lines
+46
to
50
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Restore lowercase URL & clean up "alot" / punctuation Using capitals inside a GitHub Pages domain can break the link. Also, "alot" → "a lot", and commas added for readability. -The GitHub action JWT token includes alot of useful fields such as `ref`, `sha`, `runner_environment` etc. however it is +The GitHub Actions JWT token includes a lot of useful claims such as `ref`, `sha`, and `runner_environment`; however, it is ... -about this is in this article: https://catnekaise.GitHub.io/GitHub-actions-abac-aws/cognito-identity/. +about this is in this article: https://catnekaise.github.io/github-actions-abac-aws/cognito-identity/. 📝 Committable suggestion
Suggested change
The GitHub action JWT token includes alot of useful fields such as `ref`, `sha`, `runner_environment` etc. however it is
challenging to write an AWS trust policy to match for these fields since only `aud` and `sub` fields are supported. Using cognito
identity it is possible to remap the fields into principal tags which allows them to be matched in the trust policy. More information
about this is in this article: https://catnekaise.github.io/github-actions-abac-aws/cognito-identity/.
about this is in this article: https://catnekaise.GitHub.io/GitHub-actions-abac-aws/cognito-identity/.
The GitHub Actions JWT token includes a lot of useful claims such as `ref`, `sha`, and `runner_environment`; however, it is
challenging to write an AWS trust policy to match for these fields since only `aud` and `sub` fields are supported. Using cognito
identity it is possible to remap the fields into principal tags which allows them to be matched in the trust policy. More information
about this is in this article: https://catnekaise.github.io/github-actions-abac-aws/cognito-identity/.
🧰 Tools🪛 LanguageTool[uncategorized] ~46-~46: Possible missing comma found. (AI_HYDRA_LEO_MISSING_COMMA) [uncategorized] ~46-~46: A comma might be missing here. (AI_EN_LECTOR_MISSING_PUNCTUATION_COMMA) 🤖 Prompt for AI Agents
|
||
If you wish to perform this mapping in digger you can specify an additional aws_cognito_oidc configuration as follows: | ||
|
||
|