-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR implements HTTP gateway support for PocketIC instances by introducing "live" mode functionality. This allows automated time progression and the ability to test HTTP canisters through an HTTP gateway instead of only the PIC actor interface.
Changes:
- Added
makeLive()andstopLive()methods to PocketIC to enable/disable auto progress and HTTP gateway - Created a new HTTP example demonstrating the live mode functionality
- Updated the Todo example to showcase live mode usage with agent-js
Reviewed changes
Copilot reviewed 24 out of 26 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/pic/src/pocket-ic.ts | Added makeLive() and stopLive() methods with HTTP gateway port tracking |
| packages/pic/src/pocket-ic-client.ts | Implemented HTTP gateway and auto-progress client methods |
| packages/pic/src/pocket-ic-client-types.ts | Added type definitions for live mode requests/responses |
| packages/pic/src/http2-client.ts | Enhanced response handling for boolean returns and empty bodies |
| examples/http/* | New example demonstrating HTTP canister testing in live mode |
| examples/todo/tests/src/live-todo.spec.ts | New test demonstrating live mode with agent-js |
| dfx.json | Updated dfx version and added http canister configuration |
| package.json | Updated pnpm version and added http example test scripts |
| Cargo.toml | Added http example to workspace members |
| .node-version | Updated Node.js version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
b3ca819 to
6adb217
Compare
marc0olo
commented
Feb 17, 2026
The HTTP test is skipped on macOS CI runners because *.localhost subdomains don't resolve there (mDNSResponder is disabled by GitHub Actions). The test runs fine on Linux CI and locally on macOS.
This could be resolved upstream if the PocketIC HTTP gateway supported ?canisterId= query param routing (like IC boundary nodes do), removing the need for subdomain-based DNS resolution entirely. (cc @mraszyk)
This PR adds support for pocket ic "live" mode. This will enable auto progress and run an HTTP Gateway.