-
Notifications
You must be signed in to change notification settings - Fork 372
chore: use runtime_deps in //rs/tests/message_routing:queues_compatibility_test #8552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
basvandijk
wants to merge
2
commits into
master
from
basvandijk/use-runtime_deps-in-queues_compatibility_test
Open
chore: use runtime_deps in //rs/tests/message_routing:queues_compatibility_test #8552
basvandijk
wants to merge
2
commits into
master
from
basvandijk/use-runtime_deps-in-queues_compatibility_test
+47
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alin-at-dfinity
alin-at-dfinity
approved these changes
Jan 27, 2026
Contributor
@alin-at-dfinity
alin-at-dfinity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you.
cgundy
cgundy
approved these changes
Jan 28, 2026
Any commits made after this event will not be merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
After #8449 it's required to specify runtime dependencies of system-tests using the
runtime_depsparameter. This already prepares the//rs/tests/message_routing:queues_compatibility_testfor this requirement.To make this work the
rust_test_with_binarybazel macro had to be rewritten to not symlink to the test binary but to copy it instead. Otherwise the system-test would use theno_opexecutable as its dependency.