-
Notifications
You must be signed in to change notification settings - Fork 236
Use ref name as tag name instead of the constant "tobuild"#244
Open
devrandom wants to merge 1 commit into
Open
Use ref name as tag name instead of the constant "tobuild" #244devrandom wants to merge 1 commit into
devrandom wants to merge 1 commit into
Conversation
abitmore
commented
Jan 25, 2021
Contributor
Thanks. I'll test and report back.
abitmore
commented
Jan 25, 2021
Contributor
Unfortunately this does not work when checking out a commit or a branch, since git describe --tags may return different result after added the new tag.
Ideally we should avoid adding tags. I'll take a look to see how to fix it.
GIT-DESCRIBE(1) Git Manual GIT-DESCRIBE(1)
NAME
git-describe - Describe a commit using the most recent tag reachable from it
SYNOPSIS
git describe [--all] [--tags] [--contains] [--abbrev=<n>] [<commit-ish>...]
git describe [--all] [--tags] [--contains] [--abbrev=<n>] --dirty[=<mark>]
DESCRIPTION
The command finds the most recent tag that is reachable from a commit.
If the tag points to the commit, then only the tag is shown. Otherwise, it suffixes
the tag name with the number of additional commits on top of the tagged
object and the abbreviated object name of the most recent commit.
By default (without --all or --tags) git describe only shows annotated tags.
For more information about creating annotated tags see the -a and -s options
to git-tag(1).
...
--tags
Instead of using only the annotated tags, use any tag found in refs/tags
namespace. This option enables matching a lightweight (non-annotated) tag.
...
abitmore
commented
Jan 25, 2021
Contributor
It turns out that
- by fetching only the target commit/tag/branch (aka Specifically fetch the requested commit #238 ) gitian-builder saves bandwidth and etc, although it is sufficient for the build step itself, but no additional info is fetched which might be useful or needed for next steps for building;
- by fetching all heads and tags it makes more info available, with a trade-off that more data gets transferred.
Apparently we can't have both. Perhaps a better approach is to define a new option, e.g. --fetch-all, so that everyone would be happier?
abitmore
commented
Jan 25, 2021
Contributor
See #245.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dongcarl @abitmore - here's yet another improvement to #238, naming the local tag the same as the ref that was requested on the command line. This play better with
git describe --tags.Review / test would be welcome.
Fixes #243.