-
-
Notifications
You must be signed in to change notification settings - Fork 845
Compile an arm64 build for macOS#254
Open
liamdawson wants to merge 1 commit intodevhubapp:master from
Open
Conversation
jmarbutt
commented
Feb 26, 2022
I feel like the non-arm version is using a significant amount of battery when unplugged, does this help resolve that?
allpossumsarewaterpossums
allpossumsarewaterpossums
approved these changes
Oct 10, 2022
"electron": "11.0.3",
"electron-builder": "22.9.1",
"electron-builder": "22.14.5",
"electron-devtools-installer": "3.1.1",
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@allpossumsarewaterpossums I feel like GitHub might have cut off a question you were about to ask?
allpossumsarewaterpossums
allpossumsarewaterpossums
approved these changes
Oct 21, 2022
brentsmith721
commented
Apr 12, 2023
Is there any plans to merge this anytime soon? Just switched to an M1 Macbook and would love to see this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using an M1 Macbook now, and I noticed that DevHub is a bit of an outlier for CPU usage on my machine. I also noticed that it doesn't offer an
arm64build for macOS, so I thought I'd try my hand at making one.I built a local version of the app from https://github.com/devhubapp/devhub/releases/tag/v0.102.0 using this approach, so you should be able to backport it and cut a new release from that tag (or just build the
arm64artifacts) if you were so inclined.(I managed to build a universal binary, but that increased the size of the
.dmgby ~40%, which felt like an unreasonable amount of overhead)