Skip to content

Navigation Menu

Sign in
Sign up

Fix broken example in the README.md - #92

Open
boazberman wants to merge 1 commit into
developit:master from
boazberman:master
Open

Fix broken example in the README.md #92
boazberman wants to merge 1 commit into
developit:master from
boazberman:master

Conversation

@boazberman

@boazberman boazberman commented Jun 16, 2018

Copy link
Copy Markdown

In the example store.setState was called with what could be a stale state. In order to use the current state, one must call store.getState. Similar to how in React if you call setState without a callback it is a potential bug.

In the example store.setState was called with what could be a stale state. In order to use the current state, one must call store.getState. Similar to how in React if you call setState without a callback it is a potential bug.

boazberman commented Jun 16, 2018
edited
Loading

Copy link
Copy Markdown
Author

I've spent a lot of time searching for this API, and only found it in the declaration file.
If I'm mistaking for it's need, I would be more then grateful to learn.

Copy link
Copy Markdown
Owner

I believe there's another example that shows the getState() version - perhaps we'd be better off showing a synchronous function for this example? I just wanted to have a way to show both.

Copy link
Copy Markdown
Author

Well, my difficulty was that I just could not understand how one can manipulate the state object after an async operation happened, and expect the results to be valid, as the state could change during that period, but the state object being manipulated is the old state. If you think there is no need in this example I understand, I just though it will save some people from having bugs caused by an asynchronous behavior. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /