Skip to content

Navigation Menu

Sign in
Sign up

fix #171 - remove warnings about deprecated hook on react 16.9.0^ - #172

Merged
developit merged 4 commits into
developit:master from
Akiyamka:fix-will-receive-props
Jun 17, 2020
Merged

fix #171 - remove warnings about deprecated hook on react 16.9.0^ #172
developit merged 4 commits into
developit:master from
Akiyamka:fix-will-receive-props

Conversation

@Akiyamka

@Akiyamka Akiyamka commented Aug 23, 2019

Copy link
Copy Markdown
Contributor

This will fix issue with warnings.
Probably will be better migrate to getDerivedStateFromProps hook with null return, but I not sure how I can call static method it this case

btzr-io and Komzpa reacted with hooray emoji

Copy link
Copy Markdown
Contributor

Very nice ;)

Comment thread src/integrations/react.js

Komzpa commented Dec 2, 2019

Copy link
Copy Markdown

Hi! Can this be merged, or is there any other thing to adjust? :)

glenndehaan and Akiyamka reacted with thumbs up emoji

lkmill commented Dec 27, 2019

Copy link
Copy Markdown

@Akiyamka hello stranger. i opened a couple of pull requests with rather substantial changes that i personally think greatly improves unistore and was looking for some feedback on. i'm assuming @developit is busy and meanwhile i was hoping to get this feedback from elsewhere. since you have opened a pull request yourself i assume you are familiar with the package and would love to hear what you think about the changes i propose. you can find them at #182 and #183. the second one builds upon the changes from the first.

Copy link
Copy Markdown

@developit Any chance this could be merged? :)

Copy link
Copy Markdown

For context, my reason for wanting this PR merged is because when using unistore with React Native we get this deprecation warning on every reload.

Screenshot 2020年05月22日 at 14 41 42

Copy link
Copy Markdown
Owner

@hesselbom ooh, that's quite the intrusive warning. I'll try to get this merged and cut a release today.

lkmill commented May 22, 2020

Copy link
Copy Markdown

@developit it was very simple to rewrite the react integration to use hooks instead and the size shrunk considerably. i have a WIP at #186

developit merged commit eafd796 into developit:master Jun 17, 2020

Copy link
Copy Markdown
Owner

Published as 3.5.2.

Akiyamka and Komzpa reacted with hooray emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@developit developit developit approved these changes
+1 more reviewer
@eduardoborges eduardoborges eduardoborges approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /