-
Notifications
You must be signed in to change notification settings - Fork 194
Add checks for other shadow and passwd/group files into os-02 and os-03 rules#162
Open
cmhe wants to merge 2 commits into
Open
Add checks for other shadow and passwd/group files into os-02 and os-03 rules #162cmhe wants to merge 2 commits into
cmhe wants to merge 2 commits into
Conversation
@cmhe
cmhe
force-pushed
the
ISSUE-161
branch
2 times, most recently
from
October 25, 2021 08:14
0bd9bca to
81489d9
Compare
Contributor
Author
I shorted the control documentation in order to pass the Metrics/BlockLength: Block has too many lines. [36/35] style check.
Not sure how much good such an arbitrary check will do :/
chris-rock
chris-rock
requested changes
Oct 26, 2021
Currently only `/etc/shadow` is checked to have the right permissions, but there are other files that can/could contain password hashes as well, which are not checked yet: - /etc/shadow- (a backup file for /etc/shadow) - /etc/gshadow (contains group password hashes) - /etc/gshadow- (a backup file for /etc/gshadow-) While the control requires `/etc/shadow` and `/etc/gshadow` to exist, the rules for their backup counterparts are a bit more relaxed. The checks will be skipped, if those files do not exist. Signed-off-by: Claudius Heine <ch@denx.de>
Currently only `/etc/passwd` is checked to have the right permissions, but there are other files that contain unix account related configuration: - /etc/passwd- (a backup file for /etc/passwd) - /etc/group (contains group configuration and membership) - /etc/group- (a backup file for /etc/group-) While the control requires `/etc/passwd` and `/etc/group` to exist, the rules for their backup counterparts are a bit more relaxed. The checks will be skipped, if those files do not exist. Signed-off-by: Claudius Heine <ch@denx.de>
schurzi
commented
Nov 7, 2021
Contributor
I shorted the control documentation in order to pass the
Metrics/BlockLength: Block has too many lines. [36/35]style check.Not sure how much good such an arbitrary check will do :/
We already had a discussion on this. https://github.com/orgs/dev-sec/teams/contributors/discussions/3
I think I will have some time to update our linting to cookstyle in the coming week. Currently we have a kind of arbitrary/default rubocop style set, that is not entirely optimal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This adds the checks for the other shadow and passwd files into the existing rules os-02 and os-03.
An alternative solution would be to create additional rule ids, in order to prevent changing the existing ones. However it does make sense to me to handle all similar files in one rule, instead of creating additional one.
It should lessen the maintenance overhead.
If changing existing rules it not possible, then I would be willing to create additional rules for those other files.
Closes: #161