Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Compiler: NonReactive annotation#1

Draft
srubin wants to merge 6 commits intomain from
steve/stable-handler
Draft

Compiler: NonReactive annotation #1
srubin wants to merge 6 commits intomain from
steve/stable-handler

Conversation

@srubin
Copy link

@srubin srubin commented Feb 6, 2026

Summary

How did you test this change?

srubin added 3 commits February 6, 2026 08:55
Prompt: Looking at @compiler/packages/babel-plugin-react-compiler/src/__tests__/fixtures/compiler/stable-handler/stable-handler-prop-basic.expect.md -- I see
 two potential problems. It looks to me like the onClick that is being passed to <button> will be re-created whenever `value` changes. It also looks
 like `t1` is only capturing the value of `onSubmit` when `value` changes. What we want instead is for `onClick` to never update, and to always
 capture the latest values of `value` and `onSubmit`.
@srubin srubin self-assigned this Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /