-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
fb62049 to
d4973bd
Compare
56d1694 to
61f613b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 61f613ba1b
i️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 Badge Align React DOM with React in the Rspress lock entries
Every @rspress/core instance now resolves React 19.2.8 together with react-dom 19.2.7, whereas the previous lockfile kept both at 19.2.7. React 19 renderers enforce an exact core/renderer version match, so loading React DOM during the Rspress build aborts with the incompatible-version error and breaks the required binpm, nodeup, and public documentation test/build jobs. Regenerate the lockfile with matching React and React DOM patch versions.
AGENTS.md reference: apps/AGENTS.md:L80-L82
Useful? React with 👍 / 👎.
6585ccd to
279b2b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 279b2b0ef0
i️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 Badge Update the DevHud validator for pinned action refs
Pinning these action references causes pnpm --filter devhud test to fail because assertMobileCi in apps/devhud/scripts/mobile-policy.mjs:119-121 still requires the literal strings dorny/paths-filter@v4 and pnpm/action-setup@v5. This is immediately reproducible with node apps/devhud/scripts/mobile-policy.test.mjs; moreover, the workflow includes .github/workflows/CI.yml in the DevHud path filters, so this commit activates the desktop matrix jobs at .github/workflows/CI.yml:829-833, where each runs the failing test before packaging. Update the validator alongside the pinned workflow references.
Useful? React with 👍 / 👎.
c9e47fb to
ee7b735
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ee7b735ec8
i️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 Badge Update private-workflow assertions for pinned actions
Pinning download-syft here and setup-java in the mobile job leaves scripts/release/devhud-private-workflow.test.mjs matching the old tag-based strings. The plan job runs that suite before producing either a plan-only result or allowing signed packaging, and node --test scripts/release/*.test.mjs now fails two assertions (download-syft@v0.21.0 count and setup-java@v5 presence), so every manual invocation stops in validation. Update these workflow assertions to recognize the pinned references.
AGENTS.md reference: AGENTS.md:L133-L133
Useful? React with 👍 / 👎.
8d42b9b to
7e411b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7e411b135d
i️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2 Badge Update the Ubuntu test delimiter for the pinned action
When upload-artifact is pinned here, both Ubuntu-specific slices in scripts/release/devhud-private-workflow.test.mjs:13,60 still search for actions/upload-artifact@v7. That delimiter now returns -1, so slice() extends almost to the end of the workflow instead of stopping at the desktop job; the lifecycle assertions can therefore be satisfied by commands moved into later jobs and no longer enforce their intended scope. Match the pinned reference or use a stable step/job boundary.
Useful? React with 👍 / 👎.
7e411b1 to
3259446
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3259446de0
i️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 Badge Add an explicit stable toolchain input
When either signed desktop matrix or the mirrored mobile matrix runs, pinning this action by SHA while omitting with.toolchain makes the action treat the SHA as the requested Rust toolchain and pass it to rustup, so toolchain setup fails before packaging. The upstream input contract states that toolchain defaults to the action version specifier; keep the immutable action ref but explicitly set toolchain: stable at both this step and the copy near line 412.
Useful? React with 👍 / 👎.
20febc0 to
22113d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2c86c88b7d
i️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 Badge Update the Docker contract assertion for the pinned base
When either the devhud-api-self or devhud-release-contracts CI job runs, scripts/release/devhud-private-workflow.test.mjs:31 still requires the exact unpinned text node:24-bookworm-slim AS administrator-assets; this digest-qualified FROM line makes node --test scripts/release/*.test.mjs fail before packaging even though the Docker stage still generates the administrator bundle. Update the assertion to accept and validate the required digest-pinned form.
AGENTS.md reference: servers/AGENTS.md:L15-L16
Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
This PR contains the following updates:
^7.29.6→7.29.7^2.0.14→2.0.14^29.5.14→29.5.146323debd23441a3e5f45b924ae3ab6effb02499707043fb46a930d0a2.0.16→=2.1.2ecfaec937fe631ceb8a2b6c977a6^9.39.4→9.39.4~9.2.0→9.2.0afa5c87afa5c87564e3660.8.3→=0.8.3^29.7.0→29.7.0^53.0.14→53.0.14^2.1.4→2.1.4ba849c6b906afffc06bc15d1d70e3.1.3→=3.1.41.0.145→=1.0.1491.0.177→=1.0.1773.2.0→=3.4.0cad07c2ba7bc0a3bb12733.18.0→=3.25.01.0.114→=1.0.116^10.9.2→10.9.2^2.9.14→2.9.18^5.9.3→5.9.3Add the preset
:preserveSemverRangesto your config if you don't want to pin your dependencies.Configuration
📅 Schedule: (in timezone America/New_York)
* 0-3 * * 1)🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.