Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

#963 Update Gradle build mechanism to support Kotlin DSL with Gradle v6.3 #974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loxal wants to merge 2 commits into deeplearning4j:master
base: master
Choose a base branch
Loading
from loxal:master

Conversation

Copy link
Contributor

@loxal loxal commented Apr 20, 2020

  • provide specific & tested Gradle version to guarantee a working example
  • convert dynamically-typed Gradle script to statically-typed Kotlin DSL
  • update dependencies
  • cleanup imports

loxal added 2 commits April 20, 2020 05:04
...L with the latest Gradle v6.3
* provide specific & tested Gradle version to guarantee a working example
* convert dynamically-typed Gradle script to statically-typed Kotlin DSL
* update dependencies
* cleanup imports
Signed-off-by: Alex <alexander.orlov@loxal.net>
@saudet saudet requested a review from RobAltena April 20, 2020 03:15
Copy link
Contributor

@RobAltena RobAltena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

loxal reacted with hooray emoji
@saudet saudet requested a review from treo April 23, 2020 01:31
Copy link
Contributor Author

loxal commented Apr 27, 2020

@treo are you going to merge this PR to master at some point?

Copy link
Member

treo commented Apr 27, 2020

There is a bigger example repository restructuring coming in a few days, in order to not loose this PR in the aftermath, I'm keeping it open to add it in afterwards and to make sure that the attribution doesn't get lost.

loxal reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treo treo Awaiting requested review from treo

1 more reviewer

@RobAltena RobAltena RobAltena approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /