-
Notifications
You must be signed in to change notification settings - Fork 339
Eval Scope#179
Open
sgrtho wants to merge 2 commits intoded:master from
sgrtho:fix-scope-poisoning-on-eval
Open
Eval Scope #179sgrtho wants to merge 2 commits intoded:master from sgrtho:fix-scope-poisoning-on-eval
sgrtho wants to merge 2 commits intoded:master from
sgrtho:fix-scope-poisoning-on-eval
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plain eval reflects to local scope, basically anything can happen. Old or rare browsers might not offer win.eval. If that happens, requests to *.js will now fail if you merge.
One could check for 'function' == typeof win.eval and provide a fallback on plain eval. But I suggest you do not. Results are quite unpredictable.