-
Notifications
You must be signed in to change notification settings - Fork 27
Shellcheck some count scripts #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
def-
commented
Dec 3, 2020
This is a bit annoying since I haven't updated the scripts here from upstream in a while.
Member
Author
ChillerDragon
commented
Mar 30, 2021
This is a bit annoying since I haven't updated the scripts here from upstream in a while.
Any plans yet to make this the proper upstream?
Member
def-
commented
Mar 30, 2021
Not really, since I then have to always care about all credentials. And we have a single repo with the maps+scripts+other stuff.
@def-
def-
force-pushed
the
master
branch
2 times, most recently
from
December 20, 2021 16:33
5450b64 to
c6f0bf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Im sure you need the wordsplit when using the variable
types=$(cat all-types)so I did not quote that it needs some more advanced workaround.I did not test any of the scripts but it should be safe refactors.