-
Notifications
You must be signed in to change notification settings - Fork 58
Open
Conversation
tromey
commented
Nov 19, 2015
Contributor
IMO this would need documentation changes and tests in order to go in (though it's not up to me...)
Anyway I wanted to note that this addresses an issue I had here: https://fedorahosted.org/gcc-python-plugin/ticket/67
tromey
commented
Nov 20, 2015
Contributor
FWIW the enum patch doesn't work for me.
I had to make two changes: first, change the generate-c-tree.py patch to use PyGcc_TreeMakeListOfPairsFromTreeListChain; and second, fix gcc-python-tree.c to use that name rather than gcc_tree_list_of_pairs_from_tree_list_chain
With those two changes, it worked as I expected -- ".values" became a Python list of (name,value) pairs.
tromey
commented
Nov 20, 2015
Contributor
I pushed my version of the enumeral type patch here: https://github.com/tromey/gcc-python-plugin/tree/add-values-to-EnumeralType
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I have been working on developing a plugin for automatic testcase generation and I am using gcc-python-plugin. Here's a few changes I made to support record and enumeral types.
I have a few more changes but will add them in a separate request.
Thanks.