-
Notifications
You must be signed in to change notification settings - Fork 286
I suggest some minor fixes #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello, thanks for your contribution, but this will work for windows only, the reality is that production servers are linux, so the "rd" command will fail when running the CI, and the same applies for the production start script, you never use just node, you use pm2 which is far better.
for (add to Turkish locales) : Yes this is a skeleton only project so I retract it as I don't think it's necessary.
I'm ashamed of myself for hearing pm2 today.
Thanks again @aydincandan, I can add the Turkish locale, but everything else I’m afraid won’t make it, because of the reasons I gave you before. Please open a new PR against development branch, only with the tr locale and close this PR.
This is my first try, may I be missing something?