Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

I suggest some minor fixes #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aydincandan wants to merge 4 commits into davellanedam:master from aydincandan:master
Closed

I suggest some minor fixes #243

aydincandan wants to merge 4 commits into davellanedam:master from aydincandan:master

Conversation

Copy link

@aydincandan aydincandan commented Apr 30, 2022

This is my first try, may I be missing something?

Copy link
Owner

Hello, thanks for your contribution, but this will work for windows only, the reality is that production servers are linux, so the "rd" command will fail when running the CI, and the same applies for the production start script, you never use just node, you use pm2 which is far better.

Copy link
Author

for (add to Turkish locales) : Yes this is a skeleton only project so I retract it as I don't think it's necessary.

Copy link
Author

I'm ashamed of myself for hearing pm2 today.

Copy link
Owner

Thanks again @aydincandan, I can add the Turkish locale, but everything else I’m afraid won’t make it, because of the reasons I gave you before. Please open a new PR against development branch, only with the tr locale and close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /