Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

.add( controller ) #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
awelles wants to merge 2 commits into dataarts:master from awelles:master
Closed

.add( controller ) #237

awelles wants to merge 2 commits into dataarts:master from awelles:master

Conversation

@awelles
Copy link
Contributor

@awelles awelles commented Jun 19, 2019

.add( controller ) #4

Read through @anhr's #232 then simply implemented .add(controller).

For custom controllers extend Controller.

For instance, anhr's KnobController:

class KnobController extends Controller {
 constructor(object, property, a, b) {
 super(object, property);
 // ... set up options if needed
 const _this = this;
 //input element
 this.__input = document.createElement('input');
 this.__input.setAttribute('type', 'number');
 this.__input.style.width = '40%';
 this.updateDisplay();
 this.domElement.appendChild(this.__input);
 //button element
 var button = document.createElement('input');
 button.setAttribute('type', 'button');
 button.value = 'Set ' + property;
 button.style.width = '50%';
 button.onclick = function (e) {
 object[property] = a + b;
 _this.updateDisplay();
 }
 this.domElement.appendChild(button);
 }
 updateDisplay() {
 this.__input.value = this.getValue();
 }
}
gui.add(new KnobController(obj, 'v', 0.5, 25));

Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

i️ Googlers: Go here for more info.

Copy link
Contributor Author

awelles commented Jun 19, 2019

I signed it!

Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

i️ Googlers: Go here for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /