-
Notifications
You must be signed in to change notification settings - Fork 76
Comments
fix: only silence warnings (not fatal errors)#98
fix: only silence warnings (not fatal errors) #98coolaj86 wants to merge 4 commits intodashpay:master from
Conversation
@pshenmic
pshenmic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, looks good! But some of tests are failing
coolaj86
commented
Jun 16, 2023
Thank you, looks good! But some of tests are failing
I'll take a look in a few hours to update the tests.
I guess someone decided to update them to pass rather than figure out why they were failing the first time? 🤷♂️
It obviously should only retry 60 times when there's an error that is known to be temporary (verifying the blocks) and not for things like authentication errors or bad host and port.
493a29f to
e80f0d7
Compare
e80f0d7 to
3374cde
Compare
Note: This is NOT a deal-breaker (because it's not even our fault), but zeromq errors are still silenced: zeromq/zeromq.js#574
A possible workaround may be to test the connection beforehand by opening a TCP socket and reporting any error.
Or maybe just setting a timeout.
3374cde to
c5a6967
Compare
coolaj86
commented
Jul 12, 2023
bump
Perhaps due to a change in he behavior of
async.retryor perhaps by some other means, all connection errors (except verifying block warnings) are silenced on startup.This means that any input that guarantees permanent failure - such as a wrong password or hostname or ip address or port - will just "sit there" without any feedback to the user.
Very confusing.
This changes the behavior so that the warning is logged and then ignored, but unexpected and fatal errors will throw.
If there are other non-fatal errors, then they can be added to the
isNonFatalErrorfilter.