-
Notifications
You must be signed in to change notification settings - Fork 322
Conversation
ce87ed5 to
4f31b9b
Compare
4f31b9b to
7bb2456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the build failed for me, it tried to patch the macos binary
d-xo
commented
Apr 20, 2022
Thanks! Looks like ci is failing when trying to build cln. Not sure what's going on there...
Does this also bump us to a newer ghc version with support for arm macs (fine if not, just asking to understand).
arcz
commented
Apr 22, 2022
This should enable M1 support if it was not working already. We are building M1 releases in Echidna which obviously uses hevm and everything works. I hope fix the build over the weekend.
d-xo
commented
Apr 22, 2022
great news :)
arcz
commented
May 9, 2022
I'm still on it, I'm struggling to get the CI tests working after all the updates
@arcz sorry I should have commented here. I've been playing around with this a bit since the ghc compiler version update is a blocker for me atm.
So far I've managed to fix the cln build issue and get the shared hevm build working, but I'm still stuck on the static build. My current progress is here: https://github.com/dapphub/dapptools/compare/bump-nixpkgs.
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
🖖 add solc 0.8.14 and keep dapptools up-to-date
Fix a small typo.
Update README.md
Signed-off-by: Pascal Marco Caversaccio <pascal.caversaccio@hotmail.ch>
🖖 add solc 0.8.15 and keep dapptools up-to-date
Add support for compilation via Yul IR
Since dapphub/ds-test#30 calls to `failed()` can contain reverting branches due to the call into abi.decode(). This meant that using prove tests with the latest ds-test version would always fail with a hard error. This change updates the symbolic test stepper to correctly report `bailed` as true for branches that reverted during the call to `failed()`.
...l-fail hevm: fix prove tests for latest ds-test
arcz
commented
Jul 27, 2022
@d-xo I merged your branch and fixed the build but I don't know why this test fails:
Running test_4byte ... FAILURE
expected [transfer(address,uint256)] but was []
It first failed on my local build but then it worked fine. Not sure what's going on there.
The static build is indeed broken and I'm not sure how to fix it.
Description
hevm is currently broken in nixpkgs because
text-formatdoesn't support the new GHC that was bumped in this PR (NixOS/nixpkgs#160733). Fortunately, hevm appears to not usetext-formatso it can be removed from dependencies. To make hevm compatible with the upcoming 22.05 release of nixpkgs, I bumped nixpkgs to the latest unstable (it will branch off to become 22.05 soon NixOS/nixpkgs#165792) and updated the code to work with the newer version of GHC and dependencies (aeson in particular).Checklist