-
Notifications
You must be signed in to change notification settings - Fork 384
fix fs.read bug since node.js is upgrade #251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node.js 8 remove the old fs.read format which cause the function failed with error message Fatal error: Second argument needs to be a buffer fix the write function for it.
ibirman
commented
Jan 16, 2018
👍
psprogis
commented
Feb 12, 2018
hi guys, could you please merge these changes and publish new version on npm ?
LittleWhiteYA
added a commit
to LittleWhiteYA/crawler
that referenced
this pull request
May 26, 2018
xpolakm5
added a commit
to xpolakm5/restler
that referenced
this pull request
May 28, 2018
skolesnyk
commented
Aug 17, 2018
Common, what takes so much time to push a new this commit to master?
jc21
commented
Oct 10, 2019
Still getting this problem and it's almost 2020 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node.js 8 remove the old fs.read format which cause the function failed with error message Fatal error: Second argument needs to be a buffer
fix the write function for it.