forked from request/request
-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Conversation
The documentation for the 'encoding : null' argument does not emphasize that this is necessary for binary response data. See http://stackoverflow.com/a/14855016/368896. I've added a parenthetical comment to emphasize this in the documentation.
Consolidated warning about binary data and `encoding: null`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The documentation for the 'encoding : null' argument does not emphasize that this is necessary for binary response data, something that is not obvious - see http://stackoverflow.com/a/14855016/368896. I've added a parenthetical comment to emphasize this in the documentation. This would have saved me (and hopefully will save others).