-
Notifications
You must be signed in to change notification settings - Fork 21
explain flavors in detail #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
explain flavors in detail #90
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have a special mention for this on the Acknowledgements section, I'll rather keep it one place only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this fit into the "Why use this" section
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could remove some jargon and make it clearer that you will be able to use that command on your terminal perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we suggest to use either nvm or n, but here we offer a specific command to run that imply the user is using n. I guess that suggesting few alternatives for managing node versions is more then enough, going into offering how to install node feels a bit out of scope imho, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I get this, what do you wanted to say with "and can therefore reference any flavor resource installable via npm" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kristianmandrup
I left you some comments, I think you definitely added some very good points, let's keep revise this and we'll have an awesome documentation!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would try to keep as a basic suggestion the core flavor that come with cca, we could definitely point out to one-fits-all as an example for a more articulated flavor perhapsh? This simply because by doing so will make the readme a bit more future-proof, let's say one-fit-all will become core, or the core flavor will evolve...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a bit long on flavors, creating your own etc. Perhaps add a Wiki instead with more detailed recipes ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This part is definitely interesting but I found it a bit unclear atm. Why not focusing on explaining better how to create a flavor and less on lerna technicalities? (We use lerna for managing this mono-repo and the flavors mono-repo, but i'm not too sure is of any relevance for a flavor creator) ..apart the sparse checkout mention, good one!
Hi guys,
You are welcome to use this Readme update as you like. At least it helped me better understand how to use flavors. Might be useful for other newbies. A good, clear starting point is essential for any "framework" community ;) Too much information to memorize and assumptions to make otherwise. Sorry to cause so much "trouble"...
Please let me know if I still have some misunderstandings or made some mistakes.
My big takeaway is that in order to customise anything, you have to
ejectand work from there so it really is just a sandbox environment/playground. I understand that the basic concept is taken from React. Wondering why you still are not using inquirer/templates though? Maybe next version!Cheers!