-
-
Notifications
You must be signed in to change notification settings - Fork 30
Open
Conversation
add fetch() to return just one value when you know that your sql will return just one line that you don't need to check and make transformations
Member
I like the idea. Need to think about the best name for the method: fetch(), fetchOne(), first(), fetchFirst().
Still need to add tests
brasizza
commented
Apr 23, 2025
Author
I just keep the sema logic with fetchAll and fetch from the pdo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔍 What was changed
Adding fetch() simplifies common one-row use cases, makes intent explicit, and avoids the perf overhead of materialising an unused array.
image
🤔 Why?
Clearer intent
fetch() makes it obvious we expect one record (or null).
Code reviewers no longer have to parse an indexing expression to know this.
Avoids unnecessary allocations
fetchAll() builds a PHP array for every row returned by the database driver.
When the caller only needs the first row, we:
allocate and populate an array for all rows,
immediately destroy most of it,
pay the GC cost later.
fetch() stops reading after the first result, closes the cursor in the finally, and releases the driver buffer early. This is a measurable win on large result sets and in tight loops.
No more [0] ?? null, no more manual casts, no more "did we forget to check the array isn’t empty?" bugs. The new method returns:
an array representing the row (default FETCH_ASSOC), or
false when the result set is empty (mirrors PDO).