-
Notifications
You must be signed in to change notification settings - Fork 58
Add retain flag to mqtt trigger #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
3735943886
wants to merge
3
commits into
custom-components:master
from
3735943886:add_retain_flag_to_mqtt_trigger
Open
Add retain flag to mqtt trigger #755
3735943886
wants to merge
3
commits into
custom-components:master
from
3735943886:add_retain_flag_to_mqtt_trigger
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `retain` flag to `TRIGGER_KWARGS` in pyscript's `eval.py` to prevent a TypeError with mqtt_trigger.
Updates the message handler in `mqtt.py` to include the `retain` flag in its processed arguments.
Thanks for the PR. Can you update the docs too please?
Updates the documentation to include the 'retain' flag.
Thanks for the PR. Can you update the docs too please?
Absolutely! I've updated the docs.
While I was working on it, I noticed a small inconsistency: the descriptions for qos and payload_obj ended with a period, but the others didn't. I've gone ahead and made a small style change to add periods to the remaining descriptions, making the entire section more uniform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request enhances the
@mqtt_triggerto fully support the MQTTretainflag, passing it as a keyword argument to decorated functions. This allows pyscript automations to differentiate between new and retained messages, enabling more advanced logic.