-
Notifications
You must be signed in to change notification settings - Fork 25
Open
Conversation
jfly
jfly
requested changes
Nov 14, 2025
Member
@jfly
jfly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename to match our other icon names (lowercase).
Member
lgarron
commented
Nov 15, 2025
Also a few requests:
- I think this should be
corner_helicopter_2x2x2orcorner_helicopter_222 - The rounding of corners is a bit inconsistent. We're also not 100% consistent across all our icons, but I think they should be sharp rather than beveled/rounded unless this causes rending issues.
- I think this is quite pleasing at large scale, but the corners get very narrow at small scales. Is it possible to adjust the cuts so the stickers are closer to equal size?
@lgarron
lgarron
force-pushed
the
main
branch
from
November 17, 2025 07:58
c75c329 to
7d6353b
Compare
jfly
jfly
approved these changes
Jan 13, 2026
Member
jfly
commented
Jan 13, 2026
@hopz123, looks like the tests are failing with this new icon. Please fix and we can merge this.
Member
lgarron
commented
Jan 15, 2026
I still have a few concerns about this icon. In addition to the points above, it's also much larger than necessary — almost twice as large as any other event icon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.