-
Notifications
You must be signed in to change notification settings - Fork 12
Add options to callbacks #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #7 +/- ## ===================================== Coverage 100% 100% ===================================== Files 1 1 Lines 5 5 Branches 1 1 ===================================== Hits 5 5
Continue to review full report at Codecov.
|
Hey @sjparsons, thanks for this. It definitely sounds like a useful feature, thanks! I will review it quite soon as I am gonna be doing some updates to this lib. 👍
Hey @sjparsons, so I have updated this library to use the latest version of react-tree-walker
. At the same time I reviewed the options we were passing down to react-tree-walker
. I have now exposed the ability to provide a React "context" to your component tree for bootstrapping. This essentially can satisfy your requirements in an alternative manner.
e.g.
class Foo extends Component { bootstrap() { console.log(this.context.myBootstrapSetting) } render() { return <div>foo</div> } } bootstrapper(<Foo />,null,{myBootstrapSetting:'what_ever_you_need'}) .then(() => console.log('done'))
As you can see it's a new third parameter to the bootstrapper.
I think it would be best to keep the secondary options
parameter separate and specific to the bootstapper/react-tree-walker configuration.
What do you think?
You may have noticed I am using bootstrap
instead of asyncBootstrap
. Both work, however, asyncBootstrap
will be removed in next major release.
Hi, it would be useful to be able to pass the options object in the
asyncBootstrapper
down into the individualasyncBootstrap
callbacks.Here's an example.
This PR makes that change and also adds a test to assert this funtionality.