Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Bootstrap upgrade#635

Open
droberts-ctrlo wants to merge 25 commits into
ctrlo:dev-bootstrap from
droberts-ctrlo:bootstrap-upgrade
Open

Bootstrap upgrade #635
droberts-ctrlo wants to merge 25 commits into
ctrlo:dev-bootstrap from
droberts-ctrlo:bootstrap-upgrade

Conversation

@droberts-ctrlo

@droberts-ctrlo droberts-ctrlo commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

...changed
Removed cjs from eslint - cjs are used for internal development files, and should never be included
... dev branch
Updated files where dev changes weren't included
Updated documentation
Fixed formatting and code where this was broken on merge with current dev branch
Added fix for error on documentComponent
Updated code files with changes as required where they were included in dev
Updated file where missing function wasn't included
Further package changes and TSConfig updates
Removed knip
Updated code files with changes as required where they were included in dev
Updated to use new switch component for fullscreen
Updated formatting as this didn't update on prev commit properly
Updated as per testing results
Further changes due to buttons not displaying correctly
Updated package file
Removed bootstrap select
Bootstrap select is no longer compatible with Bootstrap v5 - the version that is compatible is still in beta and contains bugs that make it unsuitable for our use-case
Updated code to fix WCAG issue
Updated changes as per ticket
Updated datatables for more consistent colours
Fix for fullscreen switch not working as expected
Modified header for correct placement of pills in dashboard
Fixes for issues found on last run
Updated datatables
Fixes for minor bugs
Updated with fixes for BS5
@droberts-ctrlo droberts-ctrlo marked this pull request as draft June 18, 2026 10:13
@droberts-ctrlo droberts-ctrlo marked this pull request as ready for review June 19, 2026 08:33

Copy link
Copy Markdown
Contributor Author

Cypress tests are failing as they now do not automatically confirm dialogs - when running the tests interactively, they pass fine within both local and container environments.

The aim is to get all tests passing as another PR, including all unit tests that are currently skipped.

@droberts-ctrlo droberts-ctrlo changed the title (削除) Bootstrap upgrade (削除ここまで) (追記) Bootstrap upgrade (internal maintenance) (追記ここまで) Jun 19, 2026
@droberts-ctrlo droberts-ctrlo changed the title (削除) Bootstrap upgrade (internal maintenance) (削除ここまで) (追記) Bootstrap upgrade (追記ここまで) Jun 19, 2026

@pwlodarski-ctrlo pwlodarski-ctrlo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR reviewed - some minor comments added.


/**
* Initialize the markdown editor.
* @todo Fix deprecation

@pwlodarski-ctrlo pwlodarski-ctrlo Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still an up-to-date comment?

/**
* Unbind event handlers from all elements of this frame
* @param {JQuery<HTMLElement>} frame The frame to unbind event handlers from.
* @todo Fix deprecation

@pwlodarski-ctrlo pwlodarski-ctrlo Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still an up-to-date comment?

background-color: $gray-light;
.table-toggle {
tr:nth-child(odd of [data-field-is-toggled="true"]) {
background-color: #f9f9f9;

@pwlodarski-ctrlo pwlodarski-ctrlo Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be a defined constant?


thead {
background-color: $white;
background-color: #fff;

@pwlodarski-ctrlo pwlodarski-ctrlo Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this remain as $white?

th {
padding: 1rem;

background-color: #fff;

@pwlodarski-ctrlo pwlodarski-ctrlo Jun 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this use the $white constant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pwlodarski-ctrlo pwlodarski-ctrlo pwlodarski-ctrlo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /