Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix alerts if user has view limit (#1531)#626

Open
abeverley wants to merge 1 commit into
dev from
1531_limited_alerts
Open

Fix alerts if user has view limit (#1531) #626
abeverley wants to merge 1 commit into
dev from
1531_limited_alerts

Conversation

@abeverley

@abeverley abeverley commented Jun 7, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@droberts-ctrlo droberts-ctrlo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed - no apparent issues

@pwlodarski-ctrlo pwlodarski-ctrlo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR reviewed - except a minor comment, all is well.

Comment thread lib/GADS/Records.pm

my $filter = $view->filter;
my $view_id = $view->id;
trace qq(About to decode filter for view ID $view_id);

@pwlodarski-ctrlo pwlodarski-ctrlo Jun 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Debug statement?

@abeverley abeverley Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Pawel and good spot but this is actually a "proper" way of doing debugging in the code - these trace statements will only print anything when the log level is high enough.

@pwlodarski-ctrlo pwlodarski-ctrlo Jun 8, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood, thanks for clarifying Andy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@droberts-ctrlo droberts-ctrlo droberts-ctrlo left review comments

@pwlodarski-ctrlo pwlodarski-ctrlo pwlodarski-ctrlo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /