Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Paged chronology (D804)#621

Open
droberts-ctrlo wants to merge 6 commits into
ctrlo:dev from
droberts-ctrlo:paged_chronology
Open

Paged chronology (D804) #621
droberts-ctrlo wants to merge 6 commits into
ctrlo:dev from
droberts-ctrlo:paged_chronology

Conversation

@droberts-ctrlo

@droberts-ctrlo droberts-ctrlo commented May 18, 2026

Copy link
Copy Markdown
Contributor

No description provided.

abeverley and others added 4 commits May 7, 2026 13:08
This commit improves performance by linking the current version of a
record to its main stub, thereby making retrieval faster for records
with lots of versions. The version retrieval functionality is retained
for the purpose of historical view, which operates as it previously did.
This commit also includes the addition of curval subfields to the y-axis
of graphs (back-end only) which was needed to test some of the changes.
It also includes sorting for grouping, which was needed for keeping the
grouping tests working as before.

@droberts-ctrlo droberts-ctrlo left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Various files appear to be GH/Git incorrectly marking changes (as this was based off Dev) - I will keep these in, but they are marked with comments. Should they need to be removed, I shall do so on request.

One further change to push in order to remove changes that appear erroneous.

@droberts-ctrlo droberts-ctrlo May 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know what this is - was pulled through with my rebase into Dev

@droberts-ctrlo droberts-ctrlo May 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this is(?)

@droberts-ctrlo droberts-ctrlo May 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't be here - not sure why it's included this when this change is already present

@droberts-ctrlo droberts-ctrlo May 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this is

@droberts-ctrlo droberts-ctrlo May 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is here?

Comment thread t/003_chronology.t

@droberts-ctrlo droberts-ctrlo May 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs updating/changing - currently incorrect/invalid.

@droberts-ctrlo droberts-ctrlo marked this pull request as ready for review May 18, 2026 14:24

@pwlodarski-ctrlo pwlodarski-ctrlo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR reviewed - comments attached.

Comment thread lib/GADS/Record.pm Outdated
Comment thread lib/GADS/API.pm Outdated
Comment thread src/frontend/components/button/lib/load-more-chronology-button.ts Outdated
Comment thread src/frontend/components/button/lib/load-more-chronology-button.ts Outdated

@pwlodarski-ctrlo pwlodarski-ctrlo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR reviewed - all good!

Copy link
Copy Markdown
Contributor Author

This is now dependent on changes within #628 - will await this merge and update accordingly

@droberts-ctrlo droberts-ctrlo changed the title (削除) Paged chronology (削除ここまで) (追記) Paged chronology (D804) (追記ここまで) Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pwlodarski-ctrlo pwlodarski-ctrlo pwlodarski-ctrlo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /