Adds Cypress Axe and addition e2e tests#582

Open

Oliver-ctrlo wants to merge 3 commits into

ctrlo:dev from

Oliver-ctrlo:Cypress-Full-Set

Open

Adds Cypress Axe and addition e2e tests #582
Oliver-ctrlo wants to merge 3 commits into
ctrlo:dev from
Oliver-ctrlo:Cypress-Full-Set

Conversation

@Oliver-ctrlo

@Oliver-ctrlo Oliver-ctrlo commented Oct 14, 2025

Copy link

Copy Markdown

Contributor

Cleaned / modified original tests to use commands for consistency.
Commented out some of the failing tests/issues to stop cypress erroring on know issues.
Added cypress axe for WCAG accessibility testing within test 15
Removed the duplicate test 8 file called data-table as these tests are located elsewhere.
Added new test sets for the following areas: table permissions, table actions, curvals, Views, data tables, WCAG and adding/editing a record.

Oliver-ctrlo and others added 3 commits

October 14, 2025 11:12

@Oliver-ctrlo


 Adds Cypress Axe for accessiblility test and greatly extends the orig...

847d326

...inal e2e test set

@droberts-ctrlo


 Cypress changes

7de04f9

@Oliver-ctrlo


 Cypress corrections

cd2e5e3

Post peer review minor corrections and improvements.

pawelwlod

pawelwlod reviewed

Jan 13, 2026

View reviewed changes

cypress/e2e/functionality/06-tables-and-wizard.cy.ts

});

context("Basic Add/Delete tests", () => {

// Skipped test: known issue where error not appearing for invalid shorname.

@pawelwlod pawelwlod Jan 13, 2026

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling mistake in comment: "shorname".

cypress/e2e/functionality/08-set-table-permissions.cy.ts

//commented out the following because they require records in the table to appear

//cy.contains("a", "Download records").should("be.visible");

//cy.contains("a", "Field Data Purge").should("be.visible");

@pawelwlod pawelwlod Jan 13, 2026

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these commented out lines above needed if not used?

cypress/e2e/functionality/08-set-table-permissions.cy.ts

`/bulk/clone/`,

`/bulk/update/`,

`/import/`,

// `/view/0`,

@pawelwlod pawelwlod Jan 13, 2026

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this commented code needed?
If there is an issue, maybe it could be stated why for clarity.

cypress/e2e/functionality/09-bulk-table-actions.cy.ts

//No way to check upload progress so wait 5s

cy.wait(5000);

// Check upload finished without errs

@pawelwlod pawelwlod Jan 13, 2026

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling error: "errs".

cypress/e2e/functionality/10-views.cy.ts

permissionObject[permissionName] = true;

});

cy.setTablePermissionsByShortName(table_shortname, permissionObject);

// cy.addUserToDefaultGroup('test@example.com');

@pawelwlod pawelwlod Jan 13, 2026

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this commented code needed?

cypress/e2e/functionality/13-data-tables.cy.ts

expect(firstFive).to.deep.equal(sortedDesc);

});

cy.get('span.dt-column-title[role="button"]').contains('Number Field').click();

//cy.contains('span.dt-column-title[role="button"]', 'Number Field').click();

@pawelwlod pawelwlod Jan 13, 2026

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this code have errors?

cypress/e2e/functionality/16-curvals.cy.ts

import { ICurvalLayoutBuilder } from "../../support/builders/layout/interfaces";

import { goodPassword, goodUser } from "../../support/constants";

describe("Ceate/edit curvals", () => {

@pawelwlod pawelwlod Jan 13, 2026

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling error.

cypress/e2e/functionality/16-curvals.cy.ts

});

// Update all Date Fields

const dateStr = '2222年01月30日';

@pawelwlod pawelwlod Jan 13, 2026

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential indenting mistake?

cypress/support/builders/layout/LayoutBuilder.ts

//cy.get("button.btn-xs[data-delete='rule']")

//.eq(1)

//.click();

//Someone owes me a drink!

@pawelwlod pawelwlod Jan 13, 2026

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the commented code have errors?
And is the last comment needed?

cypress/support/commands.ts

bulkImportRecords(csvFilePath?: string): Chainable;

logout(): Chainable;

deleteCurrentView(): Chainable;

deleteAllViewsForTable(tableName: string): Chainable;

@pawelwlod pawelwlod Jan 13, 2026

Copy link

Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any way this could potentially be better formatted?

Labels

None yet

3 participants

@Oliver-ctrlo @pawelwlod @droberts-ctrlo

Conversation

@Oliver-ctrlo Oliver-ctrlo commented Oct 14, 2025

Uh oh!

@pawelwlod pawelwlod Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

@pawelwlod pawelwlod Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

@pawelwlod pawelwlod Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

@pawelwlod pawelwlod Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

@pawelwlod pawelwlod Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

@pawelwlod pawelwlod Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

@pawelwlod pawelwlod Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

@pawelwlod pawelwlod Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

@pawelwlod pawelwlod Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

@pawelwlod pawelwlod Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants