-
-
Notifications
You must be signed in to change notification settings - Fork 909
Denote override and final as code#162
Open
vil02 wants to merge 1 commit intocpp-best-practices:master from
Open
Denote override and final as code #162vil02 wants to merge 1 commit intocpp-best-practices:master from
override and final as code #162vil02 wants to merge 1 commit intocpp-best-practices:master from
Conversation
@vil02
vil02
force-pushed
the
missing_backticks_patch
branch
from
July 1, 2025 18:23
65a73aa to
d52387a
Compare
sorny92
sorny92
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
overrideandfinalare keywords, they deserve to be highlighted as code, similarly asdoubleandfloatin here orassertin here.Yes, this PR is just a typo fix.