-
Notifications
You must be signed in to change notification settings - Fork 394
Open
Conversation
Added venv folder, which I use for testing
Various changes made to introduce ".wallet" files (with encryption mode)
Changed a little the encription method and removed testing addresses
@adanielpincab
adanielpincab
changed the title
(削除) ADDED ENCRYPTION (削除ここまで)
(追記) ADDED PRIVATE KEY ENCRYPTION (追記ここまで)
Oct 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This new version improves the using and security of adresses:
Now addresses generated are stored in a file with .wallet extension. That makes them recognizable as simplecoin addresses by the program, so you don't have to manually enter your wallet credentials everytime you make a transaction.
But even more important: when creating a new address, the program gives you the option of encrypting it's private key with a password. If you want to do a transaction with an encrypted address, you will have to enter the password in order to get the private key. This makes the address safer, preventing the private key to be stolen by someone that could have access to the address file.
This new feature solves an important problem of issue #6 (Preventing someone from using other users wallets)