-
Notifications
You must be signed in to change notification settings - Fork 876
Open
Conversation
Signed-off-by: Shvejan Mutheboyina <shvejan@amazon.com>
Signed-off-by: Shvejan Mutheboyina <shvejan@amazon.com>
yeya24
yeya24
approved these changes
Aug 28, 2026
@yeya24
yeya24
left a comment
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
SungJin1212
SungJin1212
approved these changes
Sep 1, 2026
SungJin1212
commented
Sep 1, 2026
Member
@Shvejan
What if query_ingester_within=0s query_store_after=12h close_idle_tsdb_timeout=1h?
Current validation emits no error, but the T-11h ~ T range would be a hole.
Should we add a validation like:
closeIdleTSDBTimeout > 0 && queryStoreAfter > 0 && queryStoreAfter >= closeIdleTSDBTimeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
continuation to this pr #7323, we are also making close_idle_tsdb_timeout to be configurable per tenant because queryIngestersWithin <= closeIdleTSDBTimeout
Which issue(s) this PR fixes:
Fixes #7160
Checklist
CHANGELOG.mdupdated - the order of entries should be[ENHANCEMENT]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags