-
Notifications
You must be signed in to change notification settings - Fork 876
Draft
Conversation
kylestang
force-pushed
the
kyle/listrules-limit
branch
3 times, most recently
from
August 21, 2026 20:09
b13e6fd to
014cc97
Compare
This commit adds a limit to the number of rules returned by the ListRules prometheus API, after which the API will truncate the result and return a pagination token for the next page. If a single rule group is larger than the max, that rule group will still be returned. This is being implemented after we found that JSON serializing a very large number of rules massively spikes the ruler CPU, which causes issues with rule evaluations and request timeouts. Signed-off-by: Kyle Stang <kylestng@amazon.com>
kylestang
force-pushed
the
kyle/listrules-limit
branch
from
August 21, 2026 20:31
014cc97 to
6aa117e
Compare
danielblando
commented
Sep 10, 2026
Contributor
Thanks @kylestang. The code looks solid.
Can you update the description? It seems outdated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a limit to the number of rules returned by the ListRules prometheus API, after which the API will return 400 and an error message encourages the caller to use pagination.
This is being implemented after we found that serializing very large numbers of rules massively spikes the ruler CPU, which causes issues with rule evaluations and request timeouts.
What this PR does:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags