-
-
Notifications
You must be signed in to change notification settings - Fork 133
CLink emit click's argument contains the mouse events #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
W/o providing the (native) mouse event no consumer can react accordingly. With this change the mouse event is emitted as first argument in the click event.
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions
Please don't close.
@xidedix IMO your suggestion makes more sense, as the mouseEvent can be discarded more easily if not used, and this change is a less breaking-change.
Thanks for the suggestion!
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions
Please don't close, merge instead 😉
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions
Please don't close, merge instead 😉
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions
Please don't close, merge instead
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions
Please don't close, merge instead
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions
@mrholek another one that the bot closed, but it should get addressed instead.
Why is that bot closing contributions w/o interaction of someone from the team?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the vue-router this must be
emit('click', mouseEvent, props.href)
W/o providing the (native) mouse event no consumer can react accordingly.
With this change the mouse event is emitted as first argument in the click event.
coreui-vue/packages/coreui-vue/src/components/link/CLink.ts
Lines 44 to 46 in a5c0ad5