-
Notifications
You must be signed in to change notification settings - Fork 260
Attempt to fix defaultEvictor. #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix defaultEvictor. #254
Conversation
If `pooledResource` is not a `Resource` (but an `Error`), it won't have `lastIdleTime` thus all ifs are returning `false` meaning the `Resource` (which is already broken in some way) won't get evicted ever, they stay in the pool and this may result in a `ResourceRequest Timed Out` error (b/c all slots are occupied by stuck `Resource`s). As a solution, `idleTime` is checked, and if it is falsy, the `Resource` gets evicted. Signed-off-by: Daniel Schopper <scream314@gmail.com>
scream314
commented
Feb 10, 2019
Please someone shed some light how to interpret the eslint errors in the Travis build log, I cannot figure out, what the problem is.
cafa991 to
ea33338
Compare
sandfox
commented
Feb 19, 2019
npm run lint or yarn run lint should fix up the formatting errors which travis is complaining about.
...eError: Converting circular structure to JSON` error Signed-off-by: Daniel Schopper <scream314@gmail.com>
This is definitely not good as it is, the added JSON.stringify produces a TypeError: Converting circular structure to JSON. Currently I am testing it with util.inspect instead.
wadeDra
commented
Aug 13, 2019
I have reported ResourceRequest Timed Out here. I would like to ask what causes" pooledResource is not a Resource (but an Error)" @scream314
scream314
commented
Nov 7, 2019
Sorry, I cannot work on this anymore.
Maybe @steveetm?
If
pooledResourceis not aResource(but anError), it won't havelastIdleTimethus all ifs are returningfalsemeaning theResource(which is already broken in some way) won't get evicted ever, they stay in the pool and this may result in aResourceRequest Timed Outerror (b/c all slots are occupied by stuckResources).As a solution,
idleTimeis checked, and if it is falsy, theResourcegets evicted.Signed-off-by: Daniel Schopper scream314@gmail.com