-
Notifications
You must be signed in to change notification settings - Fork 943
feat: load config from deno.json #4327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Deno employs a dedicated configuration file named
deno.json
. This pull request introduces the capability to load commitlint configuration directly fromdeno.json
, enabling developers using Deno to eliminate the need for apackage.json
file.Description
I am opening this pull request as a draft to share the changes I've made, as some parts of the codebase are still unclear to me. I welcome feedback from more experienced contributors who can use this as a foundation. Additionally, my commit includes formatting changes made by formatter automatically executed when committing.
I have added check whether
deno.json
exists toisEsmModule
function asdeno.json
(JSR) packages support ESM only.Motivation and Context
Deno supports loading configuration from
package.json
, which allows commitlint to function seamlessly. However, if developers prefer to use onlydeno.json
for their configuration without relying on a separate config file, this is currently not feasible, as commitlint exclusively loads its configuration frompackage.json
.How Has This Been Tested?
Currently, I am unable to pass the tests due to the modifications I've implemented.
Types of changes
Checklist: