Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Minor fixes #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
iennae wants to merge 10 commits into continuousphp:master from iennae:minor_fixes
Closed

Minor fixes #17

iennae wants to merge 10 commits into continuousphp:master from iennae:minor_fixes

Conversation

Copy link

@iennae iennae commented Jul 17, 2017

Just a few minor updates to cleanup cookstyle issues. This also fixes the using upstart on latest centos. Since the docker file only has centos 7 included, I just assumed that systemd was ok which is what chef will do by default so eliminated that line. I also included a dokken driver configuration file which is standard for some of the chef community cookbooks, and also a configuration for amazon linux. I also removed the ohai recipe inclusion as it doesn't do anything right now.

iennae added 10 commits July 17, 2017 15:34
Signed-off-by: Jennifer Davis <iennae@gmail.com>
 Space missing after comma.
 action [:enable,:start]
Signed-off-by: Jennifer Davis <iennae@gmail.com>
Signed-off-by: Jennifer Davis <iennae@gmail.com>
Signed-off-by: Jennifer Davis <iennae@gmail.com>
...ate metadata with chef version info.
Signed-off-by: Jennifer Davis <iennae@gmail.com>
Signed-off-by: Jennifer Davis <iennae@gmail.com>
...ses systemd.
[root@dokken /]# systemctl status codedeploy-agent
くろまる codedeploy-agent.service - LSB: AWS CodeDeploy Host Agent
 Loaded: loaded (/etc/rc.d/init.d/codedeploy-agent; bad; vendor preset: disabled)
 Active: active (running) since Mon 2017年07月17日 23:07:11 UTC; 43s ago
 Docs: man:systemd-sysv-generator(8)
 Process: 23832 ExecStart=/etc/rc.d/init.d/codedeploy-agent start (code=exited, status=0/SUCCESS)
 CGroup: /docker/08e204bcffdc2e51f4b198c550e9c1591e8150a053f0fc37a5fedd470d28b904/system.slice/codedeploy-agent.service
 ├─23914 codedeploy-agent: master 23914
 └─23918 codedeploy-agent: booting child
Jul 17 23:07:11 dokken systemd[1]: Starting LSB: AWS CodeDeploy Host Agent...
Jul 17 23:07:11 dokken codedeploy-agent[23832]: Starting codedeploy-agent:
Jul 17 23:07:11 dokken systemd[1]: Started LSB: AWS CodeDeploy Host Agent.
Signed-off-by: Jennifer Davis <iennae@gmail.com>
Signed-off-by: Jennifer Davis <iennae@gmail.com>
Signed-off-by: Jennifer Davis <iennae@gmail.com>
... ohai cookbook 4.0
Signed-off-by: Jennifer Davis <iennae@gmail.com>
Copy link
Contributor

Pierozi commented Jul 18, 2017

Hello @iennae, many thanks for your contribution 👏
We are a small team and have not always the time to keep updated the cookbook.

Your contribution is highly appreciate 💯

@Pierozi Pierozi self-assigned this Jul 26, 2017
@Pierozi Pierozi added this to the v1.0.0 milestone Aug 4, 2017
@iennae iennae deleted the minor_fixes branch October 17, 2018 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oswaldderiemaecker oswaldderiemaecker Awaiting requested review from oswaldderiemaecker

@Pierozi Pierozi Awaiting requested review from Pierozi

Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /