-
Notifications
You must be signed in to change notification settings - Fork 194
Comments
Open
Conversation
EXPERIMENTAL: Consider this commit a chain of experimental changes, which likely break the pacakge.
This fixes an issue where the piscina worker pool crashes with `FATAL ERROR: v8::FromJust Maybe value is Nothing` Supposedly, this is the worker running out of memory? No idea. As a fix, we explicitly pick boundaries for queue and thread size in piscina.
⚠️ No Changeset found
Latest commit: 5c827a3
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This PR begins to parallelize the (presumably) computationally most expensive step: parsing source files. It does so by introducing a worker pool, which the main thread delegates to. Summarized changes:
makeCacheItemFromFilePathwith a thread worker pool via piscina.makeCacheItemFromFilePathto make input/result serializable.This PR is considered WIP, with some things left to do:
Mandatory:
Optional:
makeCacheItemFromFilePath.