-
Notifications
You must be signed in to change notification settings - Fork 126
Move @lingui/core to regular dependencies - #1912
Open
Tijn Kersjes (tkers) wants to merge 2 commits into
Open
Conversation
Marking pull request as stale since there was no activity for 30 days
@github-actions
github-actions
Bot
added
the
stale
Used to mark when there was no activity for a set period of time
label
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This commit f2ece01 seems to introduce a (non-dev) dependency to
@lingui/core, but the package.json file was not updated to reflect that, causing this module to break in production builds where devDependencies are not installed.Update:
Might want to look at a different solution as I see
@lingui/corelisted as peer dependency, but prior to the latest patch this was not an actual requirement.