Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

tests: run all py tests with cgroupfs and systemd#1820

Draft
kolyshkin wants to merge 1 commit into
containers:main from
kolyshkin:cg-sd
Draft

tests: run all py tests with cgroupfs and systemd #1820
kolyshkin wants to merge 1 commit into
containers:main from
kolyshkin:cg-sd

Conversation

@kolyshkin

@kolyshkin kolyshkin commented Jul 9, 2025 •
edited by sourcery-ai Bot
Loading

Copy link
Copy Markdown
Collaborator

Many python tests do not run with systemd, and it makes sense to do so.

Summary by Sourcery

Iterate over both cgroupfs and systemd managers when running all Python tests and propagate CGROUP_MANAGER into test utilities to support both cgroup backends.

New Features:

  • Detect and include systemd cgroup manager in test runs when available
  • Run each test under both cgroupfs and systemd, generating separate logs and TRS files

Enhancements:

  • Default cgroup_manager in run_and_get_output to the CGROUP_MANAGER environment variable when not explicitly provided

sourcery-ai Bot commented Jul 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Reviewer's Guide

Tests now run under both cgroupfs and systemd when available, with the cgroup manager propagated from environment into the test utility for consistent behavior.

File-Level Changes

Change Details Files
Run Python tests under both cgroupfs and systemd in CI script
  • Detect if systemd is supported by the runtime
  • Loop over 'cgroupfs' and 'systemd' for test execution
  • Export CGROUP_MANAGER per iteration
  • Suffix log and TRS filenames with manager name
 tests/run_all_tests.sh
Allow tests_utils to pick cgroup manager from environment when not explicitly passed
  • Change default cgroup_manager parameter to None
  • If None, read CGROUP_MANAGER env var or fallback to 'cgroupfs'
  • Pass selected cgroup_manager to crun invocation
 tests/tests_utils.py
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@giuseppe giuseppe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

giuseppe commented Jul 9, 2025

Copy link
Copy Markdown
Member

I'll merge once you are fine with it (no Draft)

Copy link
Copy Markdown
Collaborator Author

This is a draft because I'm not quite sure how the tests are actually run and whether this script is used (if not, we need to supply different value of CGROUP_MANAGER env var, this can probably be done via Makefile).

 

Many python tests do not run with systemd, and it makes sense to do so.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

Copy link
Copy Markdown

TMT tests failed. @containers/packit-build please check.

Copy link
Copy Markdown
Collaborator Author

It appears that tests/run_all_tests.sh is not used (and is not working since , so patching it doesn't make sense. It needs to be removed I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /