-
Notifications
You must be signed in to change notification settings - Fork 58
style(#3160): use explicit 0o octal notation for file permissions#3329
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
style(#3160): use explicit 0o octal notation for file permissions #3329fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Replace all old-style Go octal literals (e.g., 0644, 0755) with the explicit 0o prefix notation (0o644, 0o755) introduced in Go 1.13. The 0o prefix makes the numeric base unambiguous and prevents visual confusion with decimal numbers. This is a semantics-preserving change across 42 files covering production code, test files, acceptance tests, and benchmarks. All os.OpenFile, os.WriteFile, os.MkdirAll, os.Chmod, os.Mkdir, afero.WriteFile, and tar.Header Mode calls are updated. Note: TestWriteReport in internal/validate failed due to sandbox network restrictions (sigstore TUF CDN blocked), not related to this change. Closes #3160
Review
Findings
No findings.
@fullsend-ai-review
fullsend-ai-review
Bot
added
the
ready-for-merge
All reviewers approved — ready to merge
label
Jun 3, 2026
st3penta
st3penta
approved these changes
Jun 4, 2026
st3penta
commented
Jun 4, 2026
Contributor
/fs-fix rebase on top of main and resolve the merge conflicts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace all old-style Go octal literals (e.g., 0644, 0755) with the explicit 0o prefix notation (0o644, 0o755) introduced in Go 1.13. The 0o prefix makes the numeric base unambiguous and prevents visual confusion with decimal numbers.
This is a semantics-preserving change across 42 files covering production code, test files, acceptance tests, and benchmarks. All os.OpenFile, os.WriteFile, os.MkdirAll, os.Chmod, os.Mkdir, afero.WriteFile, and tar.Header Mode calls are updated.
Note: TestWriteReport in internal/validate failed due to sandbox network restrictions (sigstore TUF CDN blocked), not related to this change.
Closes #3160
Post-script verification
agent/3160-explicit-octal-notation)d5a1551b2ae45d8ae67995bc240d0c3219ddade3..HEAD)